Re: Patch to set timezone once instead of every call

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Barry Lind <barry(at)xythos(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, pgsql-jdbc(at)postgresql(dot)org
Subject: Re: Patch to set timezone once instead of every call
Date: 2001-07-02 16:20:40
Message-ID: 200107021620.f62GKeF09310@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc pgsql-patches

Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

> This patch moves the setting of the timezone on the SimpleDateFormat
> object inside the initialization section instead of doing it everytime
> the setTimestamp method is called. Thanks to Dave Harkness for this
> suggestion.
>
> thanks,
> --Barry
>

> *** ./interfaces/jdbc/org/postgresql/jdbc2/PreparedStatement.java.orig Sat Jun 30 17:19:36 2001
> --- ./interfaces/jdbc/org/postgresql/jdbc2/PreparedStatement.java Sat Jun 30 17:20:47 2001
> ***************
> *** 369,377 ****
> SimpleDateFormat df = (SimpleDateFormat) tl_tsdf.get();
> if(df==null) {
> df = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
> tl_tsdf.set(df);
> }
> - df.setTimeZone(TimeZone.getTimeZone("GMT"));
>
> // Use the shared StringBuffer
> synchronized(sbuf) {
> --- 369,377 ----
> SimpleDateFormat df = (SimpleDateFormat) tl_tsdf.get();
> if(df==null) {
> df = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
> + df.setTimeZone(TimeZone.getTimeZone("GMT"));
> tl_tsdf.set(df);
> }
>
> // Use the shared StringBuffer
> synchronized(sbuf) {

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-jdbc by date

  From Date Subject
Next Message Barry Lind 2001-07-02 16:21:35 Re: [INTERFACES] New code for JDBC driver
Previous Message Bruce Momjian 2001-07-02 16:20:13 Re: Patch to remove connection hook and JDK 1.3 dependencies

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-07-02 16:35:59 Re: Patch for dead code in JDBC PG_Stream
Previous Message Bruce Momjian 2001-07-02 16:20:13 Re: Patch to remove connection hook and JDK 1.3 dependencies