Skip site navigation (1) Skip section navigation (2)

Re: Removal of temp tables

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Removal of temp tables
Date: 2001-06-14 17:53:50
Message-ID: 200106141753.f5EHro213955@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I was wondering that.  The old vacuum file detection patch had the sort
> > files going into /pg_sorttemp and files called pid_.  Your changes made
> > it pg_tempfile directory and pg_temp file names.  I like the older names
> > that made them clear they were _not_ temp tables.  Seemed you wanted
> > them to have similar names for reasons I couldn't figure.
> 
> I'm not wedded to those names; if you have a better idea, let's hear it.
> I changed it because I didn't like the use of the word "sort"; temp
> files are not used only for sorts, but for several other things, and so
> I wanted to see them called temp files not sorttemp files.  But if you
> want to change them so that they look even less like the logical names
> of temp relations, that's OK with me.

OK, I will do that.  What else do we do with them except sorts?  Seems
pid_ was a good file name because they are always based on pid in
storage/file/fd.c.  The directory could be called simply 'tempfile' with
no pg_.  How is that?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2001-06-14 18:10:45
Subject: Re: Removal of temp tables
Previous:From: Tom LaneDate: 2001-06-14 17:51:28
Subject: Re: Removal of temp tables

pgsql-patches by date

Next:From: Stephen RamseyDate: 2001-06-14 18:00:20
Subject: possible patch to increase number of hash overflow pages?
Previous:From: Tom LaneDate: 2001-06-14 17:51:28
Subject: Re: Removal of temp tables

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group