Skip site navigation (1) Skip section navigation (2)

Re: Australian timezone configure option

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Chris Dunlop <chris(at)onthe(dot)net(dot)au>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Australian timezone configure option
Date: 2001-06-13 17:16:51
Message-ID: 200106131716.f5DHGpH21047@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
> On Mon, Jun 11, 2001 at 11:53:59PM -0400, Bruce Momjian wrote:
> > > Hi,
> > > 
> > > Being in Australia, it's always been a minor pain building the support
> > > for Australian timezone rules by defining USE_AUSTRALIAN_RULES to the
> > > compiler.  Not to mention the not inconsiderable pain involved in pawing
> > > through the code and documentation trying to work out why the timezones
> > > were wrong in the first place.
> > 
> > OK, this patch makes Australian_timezones a GUC option.  It can be set
> > anytime in psql.  The code uses a static variable to check if the GUC
> > setting has changed and adjust the C struct accordingly.  I have also
> > added code to allow the regression tests to pass even if postgresql.conf
> > has australian_timezones defined.

Here is a new version of the patch.  Tom added callbacks to GUC boolean
variables so I was able to make a separate Australian lookup table and
clear the cache if anyone changes the setting.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2001-06-13 17:22:01
Subject: Re: Re: [PATCHES] Fw: Isn't pg_statistic a security hole - Solution Proposal
Previous:From: Vince VielhaberDate: 2001-06-13 17:16:18
Subject: create user problem

pgsql-patches by date

Next:From: Tom LaneDate: 2001-06-13 17:22:01
Subject: Re: Re: [PATCHES] Fw: Isn't pg_statistic a security hole - Solution Proposal
Previous:From: Marko KreenDate: 2001-06-13 16:44:33
Subject: Re: reset all update

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group