Skip site navigation (1) Skip section navigation (2)

Re: Re: [HACKERS] Outstanding patches

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Hannu Krosing <hannu(at)tm(dot)ee>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL jdbc list <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: Re: [HACKERS] Outstanding patches
Date: 2001-05-28 14:14:55
Message-ID: 200105281414.f4SEEtf04206@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-jdbc
Can this patch be resubmitted with a postive-only return value?


> > +			/* I use CMD_UPDATE, because no CMD_MOVE or the like
> > +			   exists, and I would like to provide the same
> > +			   kind of info as CMD_UPDATE */
> > +			UpdateCommandInfo(CMD_UPDATE, 0, -1*estate->es_processed);
> 
> I do not think it is a good idea to return a negative count for a
> backwards move; that is too likely to break client code that parses
> command result strings and isn't expecting minus signs.  The client
> should know whether he issued MOVE FORWARD or MOVE BACKWARDS anyway,
> so just returning es_processed ought to be sufficient.
> 
> Otherwise I think the patch is probably OK.
> 
> 			regards, tom lane
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2001-05-28 14:15:23
Subject: Re: [HACKERS] Support for %TYPE in CREATE FUNCTION
Previous:From: Trond Eivind =?iso-8859-1?q?Glomsr=F8d?=Date: 2001-05-28 14:08:06
Subject: Re: Re: OpenOffice compile

pgsql-jdbc by date

Next:From: MilenDate: 2001-05-28 16:56:30
Subject: JDBC and JBuilder 4 "The driver: org.postgresql.Driver could not be loaded"
Previous:From: Bruce MomjianDate: 2001-05-28 13:22:01
Subject: Re: RE: [JDBC] ANT fix for jar creation

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group