Skip site navigation (1) Skip section navigation (2)

Re: Python (PyGreSQL) make install patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>, Pgsql-Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Python (PyGreSQL) make install patch
Date: 2001-05-25 15:33:01
Message-ID: 200105251533.f4PFX1U24582@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
> Bruce Momjian writes:
> 
> > Patch applied.  Thanks.  I know you are testing a newer one but it
> > seemed worthwhile to get this in there.
> 
> No, no, no!

OK, backed out.  I knew you wanted it rewritten.  I forgot you didn't
like it.


> 
> >
> > > The attached patch changes src/interfaces/python/GNUmakefile to use the
> > > value of DESTDIR like the rest (or at least most) of the PostgreSQL
> > > makefiles.  I found this problem when trying to package a pre-built
> > > Cygwin PostgreSQL distribution, but this problem is platform independent.
> > >
> > > The problem manifests itself when one tries to install into a stagging
> > > area (e.g., to build a tarball) instead of a real install.  In this case,
> > > pg.py and _pgmodule$(SO) still end up being installed in the configured
> > > prefix directory ignoring the value of DESTDIR.
> > >
> > > Unfortunately, this patch does not handle the case where PostgreSQL
> > > and Python are configured with different prefixes.  Since the Python
>     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > Makefile is automatically generated and does not use DESTDIR, I believe
> > > that this issue will be difficult to correct.  If anyone has ideas on
> > > how to fix this issue, then I'm quite willing to rework the patch to
> > > take the suggestion into account.
> > >
> > > I tested this patch on Cygwin and Linux.
> > >
> > > Thanks,
> > > Jason
> > >
> > > --
> > > Jason Tishler
> > > Director, Software Engineering       Phone: 732.264.8770 x235
> > > Dot Hill Systems Corp.               Fax:   732.264.8798
> > > 82 Bethany Road, Suite 7             Email: Jason(dot)Tishler(at)dothill(dot)com
> > > Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com
> >
> > [ Attachment, skipping... ]
> >
> > >
> > > ---------------------------(end of broadcast)---------------------------
> > > TIP 3: if posting/reading through Usenet, please send an appropriate
> > > subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> > > message can get through to the mailing list cleanly
> >
> >
> 
> -- 
> Peter Eisentraut   peter_e(at)gmx(dot)net   http://funkturm.homeip.net/~peter
> 
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-05-25 15:33:26
Subject: Re: Python (PyGreSQL) make install patch
Previous:From: Peter EisentrautDate: 2001-05-25 15:31:20
Subject: Re: Python (PyGreSQL) make install patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group