Skip site navigation (1) Skip section navigation (2)

Python (PyGreSQL) make install patch

From: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
To: Pgsql-Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Python (PyGreSQL) make install patch
Date: 2001-05-24 16:15:41
Message-ID: 20010524121541.N714@dothill.com (view raw or flat)
Thread:
Lists: pgsql-patches
The attached patch changes src/interfaces/python/GNUmakefile to use the
value of DESTDIR like the rest (or at least most) of the PostgreSQL
makefiles.  I found this problem when trying to package a pre-built
Cygwin PostgreSQL distribution, but this problem is platform independent.

The problem manifests itself when one tries to install into a stagging
area (e.g., to build a tarball) instead of a real install.  In this case,
pg.py and _pgmodule$(SO) still end up being installed in the configured
prefix directory ignoring the value of DESTDIR.

Unfortunately, this patch does not handle the case where PostgreSQL
and Python are configured with different prefixes.  Since the Python
Makefile is automatically generated and does not use DESTDIR, I believe
that this issue will be difficult to correct.  If anyone has ideas on
how to fix this issue, then I'm quite willing to rework the patch to
take the suggestion into account.

I tested this patch on Cygwin and Linux.

Thanks,
Jason

-- 
Jason Tishler
Director, Software Engineering       Phone: 732.264.8770 x235
Dot Hill Systems Corp.               Fax:   732.264.8798
82 Bethany Road, Suite 7             Email: Jason(dot)Tishler(at)dothill(dot)com
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

Responses

pgsql-patches by date

Next:From: Jason TishlerDate: 2001-05-24 16:16:22
Subject: Re: Cygwin Java (make install) Patch
Previous:From: Brent EwingDate: 2001-05-24 16:10:41
Subject: libpq performance issue

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group