Re: More pgindent follies

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: More pgindent follies
Date: 2001-05-23 15:58:51
Message-ID: 200105231558.f4NFwpN13274@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > I don't see the problem here. My assumption is that the comment is not
> > part of the define, right?
>
> Well, that's the question. ANSI C requires comments to be replaced by
> whitespace before preprocessor commands are detected/executed, but there
> was an awful lot of variation in preprocessor behavior before ANSI.
> I suspect there are still preprocessors out there that might misbehave
> on this input --- for example, by leaving the text "* end-of-string */"
> present in the preprocessor output. Now we still go to considerable
> lengths to support not-quite-ANSI preprocessors. I don't like the idea
> that all the work done by configure and c.h in that direction might be
> wasted because of pgindent carelessness.

I agree, but in a certain sense, we would have found those compilers
already. This is not new behavour as far as I know, and clearly this
would throw a compiler error.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephan Szabo 2001-05-23 16:21:37 Re: ADD/DROP CONSTRAINT and inheritance
Previous Message bpalmer 2001-05-23 15:57:25 Re: Not released yet, but could someone take a quick peak ...