Skip site navigation (1) Skip section navigation (2)

Re: Re: [INTERFACES] Postgres odbc driver bug

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>
Cc: Keith Millard <Kmillard(at)pumatech(dot)com>, PostgreSQL odbc list <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: Re: [INTERFACES] Postgres odbc driver bug
Date: 2001-05-09 01:53:31
Message-ID: 200105090153.f491rWd17938@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-interfacespgsql-odbc
> Bruce Momjian wrote:
> > 
> > OK, I have created a context diff of your changes, which is
> attached.
> > Can someone comment on this?  The patch appears to deal with
> > STMT_PREMATURE differently than our current code.
> > 
> > In fact, it seems to disable this code:
> > 
> >     /*
> >      * If the statement is premature, it means we already executed it from
> >      * an SQLPrepare/SQLDescribeCol type of scenario.  So just return
> >      * success.
> >      */
> >     if (stmt->prepare && stmt->status == STMT_PREMATURE)
> > 
> 
> Though this fixes the bug reported by Keith, STMT_PREMATURE
> loses its meaning and SC_pre_execute() does a non-essential
> work as a result. Possibly SQLPrepare() must be rewritten
> though I'm not sure.  

OK, I see you have applied your patch:
	
	1) [ODBC] Psqlodbc and Centura: here it is a patch
	        posted by Matteo Cavalleli
	2) [ODBC] pgsqODBC binding parameters II
	        posted by Ludek Finstrle
	3) Invalid Page Fault in PSQLODBC.DLL
	        personal mail from Johann Zuschlag

I removed it from the outstanding patches page.  

And you are saying that this patch fixes a different problem.  The user
reported his problems were fixed by that patch, so I am inclined to
apply it.

Thanks.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

Responses

pgsql-odbc by date

Next:From: Bruce MomjianDate: 2001-05-09 01:57:11
Subject: Re: Postgres odbc driver bug
Previous:From: Hiroshi InoueDate: 2001-05-09 01:16:32
Subject: Re: [ODBC] Re: Postgres odbc driver bug

pgsql-interfaces by date

Next:From: Bruce MomjianDate: 2001-05-09 01:57:11
Subject: Re: Postgres odbc driver bug
Previous:From: Hiroshi InoueDate: 2001-05-09 01:16:32
Subject: Re: [ODBC] Re: Postgres odbc driver bug

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group