Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] Cygwin PostgreSQL ESQL Patch

From: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pgsql-Patches <pgsql-patches(at)postgresql(dot)org>, Pgsql-Cygwin <pgsql-cygwin(at)postgresql(dot)org>, Michael Lemke <lemkemch(at)t-online(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: [PATCHES] Cygwin PostgreSQL ESQL Patch
Date: 2001-05-03 13:37:09
Message-ID: 20010503093709.I212@dothill.com (view raw or flat)
Thread:
Lists: pgsql-cygwinpgsql-patches
Tom,

On Thu, May 03, 2001 at 09:15:52AM -0400, Tom Lane wrote:
> Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com> writes:
> > What is the status of the following patch:
> >     http://postgresql.readysetnet.com/mhonarc/pgsql-cygwin/2001-04/msg00031.html
> 
> I recall voicing unhappiness about putting a definition of DLLIMPORT
> into sqlca.h, independent of the main one in c.h.  Not sure if there's
> any good way around that, though.  Including c.h would be a cure worse
> than the disease, probably (application namespace pollution and all that).

See the following to refresh your memory:

On Fri, Apr 20, 2001 at 02:38:53PM -0400, Tom Lane wrote:
> Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com> writes:
> > In the above mentioned URL, I suggested including c.h as another
> > possibly better solution.  However, I saw the following in ecpglib.h:
> >     /*
> >      * this is a small part of c.h since we don't want to leak all postgres
> >      * definitions into ecpg programs
> >      */
> > so I decided against including c.h in the first version of my patch.
> 
> That's a fair point.  Maybe it should be
> 
> +#ifndef DLLIMPORT
> +#ifdef __CYGWIN__
> +#define DLLIMPORT __declspec (dllimport)
> +#else
> +#define DLLIMPORT
> +#endif /* __CYGWIN__ */
> +#endif /* DLLIMPORT */

The current version of my patch is just doing what you suggested.  Are you
no longer recommending this approach as the best compromise?

> The Makefile changes look OK to me but Peter E. would be more qualified
> to comment on them.

Let's see what Peter has to say about the Makefile parts.

Thanks,
Jason

-- 
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jason(dot)Tishler(at)dothill(dot)com
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

In response to

Responses

pgsql-cygwin by date

Next:From: Tom LaneDate: 2001-05-03 13:45:16
Subject: Re: [PATCHES] Cygwin PostgreSQL ESQL Patch
Previous:From: Jason TishlerDate: 2001-05-03 13:31:26
Subject: Re: Initdb

pgsql-patches by date

Next:From: Tom LaneDate: 2001-05-03 13:45:16
Subject: Re: [PATCHES] Cygwin PostgreSQL ESQL Patch
Previous:From: Tom LaneDate: 2001-05-03 13:15:52
Subject: Re: [PATCHES] Cygwin PostgreSQL ESQL Patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group