Skip site navigation (1) Skip section navigation (2)

Re: src/backend/Makefile CDPATH Patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
Cc: Pgsql-Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: src/backend/Makefile CDPATH Patch
Date: 2001-04-23 20:10:17
Message-ID: 200104232010.f3NKAH006700@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
> Bruce,
> 
> On Mon, Apr 23, 2001 at 03:25:38PM -0400, Bruce Momjian wrote:
> > > The above is due to the following:
> > > 
> > >     $ export CDPATH=.:/home/jt:/home/jt/src:/home/jt/lib
> > >     $ echo `cd parser/ && pwd`
> > >     /home/jt/src/pgsql/src/backend/parser /home/jt/src/pgsql/src/backend/parser
> > 
> > Basically, you are telling me that if there are two matching parser
> > directories, pwd gets set to _both_ of them.  Sorry, I don't think we
> > want to work around a bug like that, should we?
> 
> I guess that I was not explicit enough, so I will try again...
> 
> The extra directory name comes from bash's builtin cd echoing the
> directory name when a match is found in the user's CDPATH.  It is *not*
> coming from pwd.

Oh, I understand now.  Good point. 

> 
> So, I still content that this is a bug in the Makefile.  The construct
> that is suspect is the following:
> 
>     prereqdir=`cd $(dir $<) && pwd`

Yep, I can see it doing that.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: Peter EisentrautDate: 2001-04-23 20:39:45
Subject: Re: src/backend/Makefile CDPATH Patch
Previous:From: Jason TishlerDate: 2001-04-23 20:05:54
Subject: Re: src/backend/Makefile CDPATH Patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group