Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] Cygwin PostgreSQL ESQL Patch

From: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pgsql-Patches <pgsql-patches(at)postgresql(dot)org>, Pgsql-Cygwin <pgsql-cygwin(at)postgresql(dot)org>, Michael Lemke <lemkemch(at)t-online(dot)de>
Subject: Re: [PATCHES] Cygwin PostgreSQL ESQL Patch
Date: 2001-04-23 18:56:23
Message-ID: 20010423145623.Q169@dothill.com (view raw or flat)
Thread:
Lists: pgsql-cygwinpgsql-patches
Tom,

On Fri, Apr 20, 2001 at 03:38:56PM -0400, Jason Tishler wrote:
> On Fri, Apr 20, 2001 at 02:38:53PM -0400, Tom Lane wrote:
> > That's a fair point.  Maybe it should be
> > 
> > +#ifndef DLLIMPORT
> > +#ifdef __CYGWIN__
> > +#define DLLIMPORT __declspec (dllimport)
> > +#else
> > +#define DLLIMPORT
> > +#endif /* __CYGWIN__ */
> > +#endif /* DLLIMPORT */
> 
> I will redo my patch with the modification suggested above.

I have redone my patch incorporating the above plus I fixed a glaring
hole now I know that sqlca.h is included by more then ESQL clients.
Without the src/makefiles/Makefile.win part, ecpg.dll no longer built
under Cygwin.

This time I have rebuilt everything from scratch on both Linux and
Cygwin without any errors.  I have also rerun the regression tests and
all passed.

I apologize for the sloppiness of my previous patch -- that will not
happen again.

Thanks,
Jason

-- 
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jason(dot)Tishler(at)dothill(dot)com
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

In response to

Responses

pgsql-cygwin by date

Next:From: Jason TishlerDate: 2001-04-24 13:03:50
Subject: Re: Re: [PORTS] Re: initdb problem
Previous:From: Jason TishlerDate: 2001-04-23 17:04:18
Subject: Re: [PORTS] connect on cygwin - v7.0

pgsql-patches by date

Next:From: Jason TishlerDate: 2001-04-23 19:11:33
Subject: src/backend/Makefile CDPATH Patch
Previous:From: Thorsten MauchDate: 2001-04-22 22:05:54
Subject: Support for JDBC Binary type

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group