Skip site navigation (1) Skip section navigation (2)

Re: [PORTS] Re: patch for minor Win32 makefile bug

From: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Fred Yankowski <fred(at)ontosys(dot)com>, pgsql-patches(at)postgresql(dot)org, pgsql-ports(at)postgresql(dot)org
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Date: 2001-04-04 21:14:55
Message-ID: 20010404171455.A802@dothill.com (view raw or flat)
Thread:
Lists: pgsql-patchespgsql-ports
Tom,
Peter,

On Wed, Apr 04, 2001 at 05:04:40PM -0400, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > It seems we're now down to
> 
> > DLLLIBS= -lcygipc -lcrypt
> 
> > but I think it can be removed completely.
> 
> > We have three uses of this variable:
> 
> > 1) Makefile.win, for building extension modules.  No module in existance
> > needs -lcygipc, and if one needs -lcrypt it can put it into SHLIB_LINK.
> 
> > 2) Makefile.shlib, see 1)
> 
> > 3) -lcrypt already comes in via LIBS (like all the other libraries),
> > -lcygipc can do the same, or be hard-coded in place.
> 
> 
> But you forgot about -lpostgres for the backend libraries (plpgsql etc).
> 
> I suppose that we might consider adding these libraries to LIBS not
> DLLLIBS, but that's cleanup work that I'd rather not try to do under
> time pressure (especially since I can't test it here).

Can we commit my updated patch for 7.1RC3?  I promise to help clean up
the above for RC4 or final.  Is this acceptable?

Thanks,
Jason

-- 
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jason(dot)Tishler(at)dothill(dot)com
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

In response to

Responses

pgsql-ports by date

Next:From: Tom LaneDate: 2001-04-04 21:19:38
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Previous:From: Tom LaneDate: 2001-04-04 21:04:40
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug

pgsql-patches by date

Next:From: Tom LaneDate: 2001-04-04 21:19:38
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Previous:From: Tom LaneDate: 2001-04-04 21:04:40
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group