Re: [PORTS] Re: patch for minor Win32 makefile bug

From: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Fred Yankowski <fred(at)ontosys(dot)com>, pgsql-patches(at)postgresql(dot)org, pgsql-ports(at)postgresql(dot)org
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Date: 2001-04-04 19:27:43
Message-ID: 20010404152743.X63@dothill.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches pgsql-ports

Tom,

On Wed, Apr 04, 2001 at 03:01:17PM -0400, Tom Lane wrote:
> Right, given that the other two need not be mentioned. What about
> -L/usr/local/lib, did that make any sense to include or not?

Hmm...I guess that my emails are too long so that you lose interest while
reading them... :,)

Anyway, see the following:

On Tue, Apr 03, 2001 at 10:38:51PM -0400, Jason Tishler wrote:
> On Tue, Apr 03, 2001 at 06:03:45PM -0400, Tom Lane wrote:
> > BTW, I see that the prior version of backend/Makefile actually defined
> > DLLLIBS as
> >
> > DLLLIBS := -L/usr/local/lib -lcygipc -lcrypt -lcygwin -lkernel32
> >
> > as compared to what Makefile.win offers (shorn of the backend):
> >
> > DLLLIBS=-lcygipc -lcygwin -lcrypt -lkernel32
> >
> > Any comments on whether -L/usr/local/lib is appropriate here or not?
>
> We have already determined that the -L/usr/local/lib option is
> superfluous for both the Cygwin Net and b20.1 releases. See the
> following for details:
>
> http://www.postgresql.org/mhonarc/pgsql-ports/2001-03/msg00049.html

> > How does this proposal sound?
>
> Works for me. Given that we'd like to package RC3 tonight, it'd be nice
> to get this done ASAP. Do you have time to work up and test a patch
> today, or shall I risk making untested changes myself?

I'm doing a build right now. The patch should follow shortly.

Jason

--
Jason Tishler
Director, Software Engineering Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp. Fax: +1 (732) 264-8798
82 Bethany Road, Suite 7 Email: Jason(dot)Tishler(at)dothill(dot)com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Jason Tishler 2001-04-04 19:42:09 Re: [PORTS] Re: patch for minor Win32 makefile bug
Previous Message Tom Lane 2001-04-04 19:01:17 Re: [PORTS] Re: patch for minor Win32 makefile bug

Browse pgsql-ports by date

  From Date Subject
Next Message Jeff Williams 2001-04-04 19:33:52 Subject: PostGreSQL - Windows 98/NT4.0/2000
Previous Message Tom Lane 2001-04-04 19:01:17 Re: [PORTS] Re: patch for minor Win32 makefile bug