Skip site navigation (1) Skip section navigation (2)

Re: [PORTS] Re: patch for minor Win32 makefile bug

From: Fred Yankowski <fred(at)ontosys(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jason(dot)Tishler(at)dothill(dot)com, pgsql-patches(at)postgresql(dot)org, pgsql-ports(at)postgresql(dot)org
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Date: 2001-04-03 19:41:12
Message-ID: 20010403144112.A54101@enteract.com (view raw or flat)
Thread:
Lists: pgsql-patchespgsql-ports
Tom,

I experimented with different ways to do this patch and discussed this
with Jason Tischler, and I now conclude that the meaning of DLLLIBS in
the two makefiles is different enough that it doesn't make sense to
try to factor-out common information to share between them.

So I wish to withdraw my proposed patch entirely, leaving the two
definitions of DLLLIBS as is.  My apologies for the confusion.

On Mon, Apr 02, 2001 at 01:48:23PM -0400, Tom Lane wrote:
> Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com> writes:
> > I now think that backend/Makefile is meant to override the definition
> > of DLLLIBS in makefiles/Makefile.win so that the build of the backend
> > will not try to link with itself (i.e., -L$(top_builddir)/src/backend
> > -lpostgres).
> 
> It seems like the real problem here is that DLLLIBS is being used for
> two different purposes.  How about offering a patch that splits it into
> two symbols, with no redefinition/overriding necessary?

-- 
Fred Yankowski           fred(at)OntoSys(dot)com      tel: +1.630.879.1312
Principal Consultant     www.OntoSys.com       fax: +1.630.879.1370
OntoSys, Inc             38W242 Deerpath Rd, Batavia, IL 60510, USA

In response to

Responses

pgsql-ports by date

Next:From: Tom LaneDate: 2001-04-03 20:04:54
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Previous:From: Bruce MomjianDate: 2001-04-03 18:14:25
Subject: Re: [PORTS] FAQ_MSWIN patch

pgsql-patches by date

Next:From: Tom LaneDate: 2001-04-03 20:04:54
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Previous:From: Bruce MomjianDate: 2001-04-03 18:14:25
Subject: Re: [PORTS] FAQ_MSWIN patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group