Skip site navigation (1) Skip section navigation (2)

Re: Re: [ODBC] Cleanup of ODBC

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Re: [ODBC] Cleanup of ODBC
Date: 2001-03-28 16:59:57
Message-ID: 200103281659.LAA28125@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-odbcpgsql-patches
OK, here is the ODBC patch I am holding.  I will run pgindent after I
apply it to 7.2 branch to properly wrap the comments.


> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I am working to clean up the comments in ODBC, and remove some blank
> > lines that make no sense being there.  This will not affect the code in
> > any way.  I should commit in a few hours.
> 
> Is it really appropriate to be doing this sort of work post-RC1?
> I see no gain and a nontrivial risk that you will break something
> without knowing it (and without providing adequate time to test it).
> 
> It's bad enough to be running pgindent at this late stage of the cycle,
> but at least pgindent is automated and relatively unlikely to make
> errors.  Massive hand edits are another story.
> 
> In short: save it for 7.2.
> 
> 			regards, tom lane
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
> 


-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

Responses

pgsql-odbc by date

Next:From: The Hermit HackerDate: 2001-03-28 17:47:33
Subject: Re: [PATCHES] Re: Cleanup of ODBC
Previous:From: Bruce MomjianDate: 2001-03-28 16:16:22
Subject: Re: Cleanup of ODBC

pgsql-patches by date

Next:From: The Hermit HackerDate: 2001-03-28 17:47:33
Subject: Re: [PATCHES] Re: Cleanup of ODBC
Previous:From: Bruce MomjianDate: 2001-03-28 16:16:22
Subject: Re: Cleanup of ODBC

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group