Re: pgindent run?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>
Cc: Alfred Perlstein <bright(at)wintelcom(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, The Hermit Hacker <scrappy(at)hub(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent run?
Date: 2001-03-23 04:51:18
Message-ID: 200103230451.XAA07904@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> Bruce Momjian wrote:
> >
> > You don't notice the value of pgindent until you have some code that
> > hasn't been run through it. For example, ODBC was not run through until
> > this release, and I had a terrible time trying to understand the code
> > because it didn't _look_ like the rest of the code. Now that pgindent
> > is run, it looks more normal, and I am sure that will encourage more
> > people to get in and make changes.
> >
>
> I see now the following comment in interfaces/odbc/statement.c.
> Though it's mine(probably), it's hard for me to read.
> Please tell me how to prevent pgindent from changing
> comments.
>
> /*
> * Basically we don't have to begin a transaction in autocommit mode
> * because Postgres backend runs in autocomit mode. We issue "BEGIN"
> * in the following cases. 1) we use declare/fetch and the statement
> * is SELECT (because declare/fetch must be called in a transaction).
> * 2) we are in autocommit off state and the statement isn't of type
> * OTHER.
> */

Sorry that happened. It is mentioned in the developer's FAQ that the
dashes prevent wrapping. I know it is hard to remember even if you know
it, and I would be glad to fix any comments that look bad.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2001-03-23 05:31:27 Re: Call for platforms
Previous Message Bruce Momjian 2001-03-23 04:48:47 Re: [HACKERS] pgindent run?

Browse pgsql-patches by date

  From Date Subject
Next Message Alfred Perlstein 2001-03-23 11:31:57 make caught doing what configure should...
Previous Message Bruce Momjian 2001-03-23 04:48:47 Re: [HACKERS] pgindent run?