Skip site navigation (1) Skip section navigation (2)

Re: Double newline bug with DBD::Pg: Where best to fix?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dan Lyke <danlyke(at)flutterby(dot)com>, pgsql-interfaces(at)postgresql(dot)org
Subject: Re: Double newline bug with DBD::Pg: Where best to fix?
Date: 2001-02-28 18:06:55
Message-ID: 200102281806.NAA05912@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-interfaces
> > Tom Lane writes:
> > 
> > > That's all fine IMHO.  But this isn't:
> > >
> > > regression=# select 'a string
> > > regression'#
> > > regression'# with a newline';
> > >         ?column?
> > > -------------------------
> > >  a string
> > > with a newline
> > > (1 row)
> > 
> > Well, *somebody* once figured that he could optimize away whitespace...
> > Not so.  Here's a patch that gets this case right:
> 

Peter, I have thought about this some more.   Seems we either add the
'quote' check, or remove the optimizations completely.  Because we have
to change it one way or the other for 7.1, it seems we should just
remove the tests totally.  Neither of us understand why they are even in
the code.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

Responses

pgsql-interfaces by date

Next:From: Tom LaneDate: 2001-02-28 19:02:13
Subject: Re: Double newline bug with DBD::Pg: Where best to fix?
Previous:From: Bruce MomjianDate: 2001-02-28 17:42:05
Subject: Re: Double newline bug with DBD::Pg: Where best to fix?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group