Re: FOR UPDATE is not allowed in this context

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: pgsql-interfaces(at)postgresql(dot)org
Subject: Re: FOR UPDATE is not allowed in this context
Date: 2001-02-22 12:55:10
Message-ID: 20010222135510.A13034@feivel.credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-interfaces

On Wed, Feb 21, 2001 at 02:03:00PM -0500, Tom Lane wrote:
> Well, for example, once a CREATE RULE has been seen, ecpg will accept
> 'old' and 'new' in all subsequent statements, because QueryIsRule is

Ouch! This is of course a bug I should have found.

> never reset. FoundInto is reset, but in the wrong place, meaning that
> "CREATE TABLE/AS SELECT may not specify INTO" might be triggered
> inappropriately, or not triggered when it's supposed to be.

Yes, I did not correct this with the last changes to SelectStmt rules.

> My advice would be to eliminate both variables and leave it to the
> backend to make the corresponding error checks.

Yes, that's one possibility. I do though prefer to do syntax checks at
compile time rather than at run time.

> BTW, I just committed some ecpg changes to modify the way
> case-conversion of keywords is done, to keep it in line with the

Thanks.

> backend. You'd said you wanted notification of such things ...

It's not a must. It just helps me track down what's going on. In the past I
did remove some changes due to not noticing something had changed in CVS.

Michael
--
Michael Meskes
Michael(at)Fam-Meskes(dot)De
Go SF 49ers! Go Rhein Fire!
Use Debian GNU/Linux! Use PostgreSQL!

In response to

Browse pgsql-interfaces by date

  From Date Subject
Next Message He Weiping(Laser Henry) 2001-02-22 13:12:00 Chinese patch for Pgaccess
Previous Message Shankar Gowda 2001-02-22 06:49:52 unable to find postgresql.jar