Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql/contrib/pg_dumpaccounts (Makefile README pg_dumpaccounts.sh)

From: Larry Rosenman <ler(at)lerctr(dot)org>
To: Vince Vielhaber <vev(at)michvhf(dot)com>
Cc: The Hermit Hacker <scrappy(at)hub(dot)org>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ned Lilly <ned(at)greatbridge(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Jan Wieck <janwieck(at)Yahoo(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql/contrib/pg_dumpaccounts (Makefile README pg_dumpaccounts.sh)
Date: 2000-11-03 01:29:39
Message-ID: 20001102192939.A26433@lerami.lerctr.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
While I see both sides, this looks like an *INTERNAL* *CORE* debate. 

 From a USER perspective the functionality is useful.  From a Software 
Development perspective, the timing stinks. 

 I'd leave it in /contrib, and make damn sure we get the right
functionality into the 7.1 release. 

LER

* Vince Vielhaber <vev(at)michvhf(dot)com> [001102 19:18]:
> On Thu, 2 Nov 2000, The Hermit Hacker wrote:
> 
> > On Thu, 2 Nov 2000, Bruce Momjian wrote:
> >
> > > > Ned Lilly <ned(at)greatbridge(dot)com> writes:
> > > > > Well, here in relatively minor form is the First Example of a Great
> > > > > Bridge Priority (which Tom, Bruce, and Jan have all predicted would
> > > > > come... ;-)
> > > >
> > > > Hmm.  I wasn't aware that Jan had done it at Great Bridge's request,
> > > > and I am going to make a point of not letting that affect my opinion ;-).
> > > >
> > > > What really got my ire up was that this change was committed several
> > > > days *after* core had agreed that 7.0.3 was frozen and ready to go except
> > > > for updating the changelog, and that it was committed with no prior
> > > > notice or discussion.  The fact that GB asked for it doesn't make that
> > > > better; if anything it makes it worse.  We wouldn't have accepted such
> > > > a patch at this late date from an outside contributor, I believe.
> > > > Jan should surely have known better than to handle it in this fashion.
> > > >
> > > > Need I remind you, also, that GB has been bugging us for several weeks
> > > > to get 7.0.3 released ASAP?  Last-minute changes don't further that
> > > > goal.
> > > >
> > > > The early returns from pghackers seem to be that people favor just
> > > > dropping the script into /contrib and not worrying about how well
> > > > tested/documented it is.  If that's the consensus then I'll shut up
> > > > ... but I do *not* like the way this was handled.
> > >
> > > I totally agree with Tom on all his points.  If people were worried we
> > > would not be objective now that we are employed by GB, they can rest
> > > easy.
> > >
> > > Also, seems like it is hidden enough in /contrib for it to stay.  While
> > > I would not have added it myself, I do not feel strongly enough to
> > > remove Jan's commit.  However, I am not going to mention it in the 7.0.3
> > > release notes.
> >
> > I do feel strongly about this ... 7.0.3 was considered in a release state
> > *before* it was committed, pending your docs changes ... personally, if we
> > leave this in contrib, my vote is to hold off the release a suitable
> > amount of time for testing purposes ... Jan has added a new feature that
> > nobody had any pre-warning about, not even other developers in the same
> > company as he is in ... not a good precedent :(
> 
> What am I missing?   We're talking about contrib.  Most things you find
> in contrib directories don't even work and you're worried about a testing
> phase?   Most folks don't even look in contrib directories unless they're
> specifically looking for something.
> 
> Vince.
> -- 
> ==========================================================================
> Vince Vielhaber -- KA8CSH    email: vev(at)michvhf(dot)com    http://www.pop4.net
>  128K ISDN from $22.00/mo - 56K Dialup from $16.00/mo at Pop4 Networking
>         Online Campground Directory    http://www.camping-usa.com
>        Online Giftshop Superstore    http://www.cloudninegifts.com
> ==========================================================================
> 
> 

-- 
Larry Rosenman                      http://www.lerctr.org/~ler
Phone: +1 972-414-9812 (voice) Internet: ler(at)lerctr(dot)org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

In response to

pgsql-hackers by date

Next:From: Nathan MyersDate: 2000-11-03 01:39:17
Subject: Re: pgsql/contrib/pg_dumpaccounts
Previous:From: Philip WarnerDate: 2000-11-03 01:24:56
Subject: Re: Unhappy thoughts about pg_dump and objects inherited from template1

pgsql-committers by date

Next:From: Nathan MyersDate: 2000-11-03 01:39:17
Subject: Re: pgsql/contrib/pg_dumpaccounts
Previous:From: The Hermit HackerDate: 2000-11-03 01:22:25
Subject: Re: Re: [COMMITTERS] pgsql/contrib/pg_dumpaccounts (Makefile README pg_dumpaccounts.sh)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group