Re: Re: [HACKERS] to_char() dumps core

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
Cc: pgsql-patches <pgsql-patches(at)postgreSQL(dot)org>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
Subject: Re: Re: [HACKERS] to_char() dumps core
Date: 2000-10-20 17:33:21
Message-ID: 200010201733.NAA21015@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> > > causes backend dump a core if n is a float/numeric ...data type AND if
> > > sum(n) returns NULL. This seems due to a bad null pointer handling for
> > > aruguments of pass-by-reference data types. I think just a simple
> > > null pointer checking at very top of each function (for example
> > > float4_to_char()) would solve the problem. Comments?
> >
> > In the 7.1devel it's correct, but here it's bug, IMHO it bear on changes
> > in the 7.1's fmgr, because code is same in both versions for this. On Monday,
> > I try fix it for 7.0.3
>
> Not, monday .. just now :-)
>
> The patch is attached... Bruce, it's again to 7.0.3!

Got it. You don't have to hit me over head all the time (just most of
the time). :-)

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Karel Zak 2000-10-20 17:48:41 Re: Now 376175 lines of code
Previous Message Peter Eisentraut 2000-10-20 17:32:59 Re: pgsql/doc (FAQ_MSWIN INSTALL_MSWIN)

Browse pgsql-patches by date

  From Date Subject
Next Message Karel Zak 2000-10-20 17:53:41 Re: Re: [HACKERS] to_char() dumps core
Previous Message Karel Zak 2000-10-20 17:18:11 Re: [HACKERS] to_char() dumps core