Date: Tuesday, September 12, 2000 @ 00:15:58
Author: momjian
Update of /home/projects/pgsql/cvsroot/pgsql/src/backend/utils/adt
from hub.org:/home/projects/pgsql/tmp/cvs-serv97855/pgsql/src/backend/utils/adt
Modified Files:
ruleutils.c
----------------------------- Log Message -----------------------------
O.K. -
Here's the multibyte aware version of my patch to fix the truncation
of the rulename autogenerated during a CREATE VIEW. I've modified all
the places in the backend that want to construct the rulename to use
the MakeRetrieveViewRuleName(), where I put the #ifdef MULTIBYTE, so
that's the only place that knows how to construct a view rulename. Except
pg_dump, where I replicated the code, since it's a standalone binary.
The only effect the enduser will see is that views with names len(name)
> NAMEDATALEN-4 will fail to be created, if the derived rulename clases
with an existing rule: i.e. the user is trying to create two views with
long names whose first difference is past NAMEDATALEN-4 (but before
NAMEDATALEN: that'll error out after the viewname truncation.) In no
case will the user get left with a table without a view rule, as the
current code does.
Ross Reedstrom
pgsql-committers by date
| Next: | From: Bruce Momjian - CVS | Date: 2000-09-12 04:15:59 |
| Subject: pgsql/src/bin/pg_dump (pg_dump.c) |
| Previous: | From: Bruce Momjian - CVS | Date: 2000-09-12 04:15:57 |
| Subject: pgsql/src/backend/commands (view.c) |