| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Richard Harvey Chapman <hchapman(at)3gfp(dot)com>, pgsql-general(at)postgresql(dot)org |
| Subject: | Re: Comments with embedded single quotes |
| Date: | 2000-06-30 17:51:51 |
| Message-ID: | 200006301751.NAA21170@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general |
[ Charset ISO-8859-1 unsupported, converting... ]
> Bruce Momjian writes:
>
> > OK, here is the patch. The problem was that quotes were being checked
> > before checking if we were in a comment. Patch applied to current tree
> > only.
>
> Nope, now we have the inverse problem. Try
>
> SELECT 'aa--bb';
>
> The timestamp test is now failing because of this.
OK, new patch. I also renamed xcomment to in_xcomment. The important
point, now commented, is that we have to test if we are in quote or an
xcomment before testing for the start of quotes or xcomments.
--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
| Attachment | Content-Type | Size |
|---|---|---|
| unknown_filename | text/plain | 6.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Len Morgan | 2000-06-30 18:38:18 | NT Binaries |
| Previous Message | caseman | 2000-06-30 16:38:33 | Inheritance of Ref Integ |