Re: Proposed cleanup of generated header files

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Proposed cleanup of generated header files
Date: 2000-05-28 18:42:46
Message-ID: 200005281842.OAA25107@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> It's bothered me for some time that backend files need to be compiled
> with -I src/backend as well as -I src/include. AFAICT this is just
> because the two header files that are generated on-the-fly (parse.h
> and fmgroids.h, formerly known as fmgr.h) are included from src/backend
> rather than being inserted into the include tree, which it seems to me
> is where they should be. Any objections if I rearrange the makefiles
> so that these files get placed under include/ when they are built,
> and then -I src/backend goes away?
>
> (In case anyone is wondering, there are no platform-dependencies in
> either file. We could distribute them as part of the distribution
> tarball --- in fact we already do so for parse.h. So I don't see
> that installing them into src/include would create any problems for
> multiplatform builds.)

Agreed.

--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message The Hermit Hacker 2000-05-28 18:59:22 Re: Proposed cleanup of generated header files
Previous Message Mitch Vincent 2000-05-28 18:42:30 Full text indexing preformance! (long)