Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] xlog.c.patch for cygwin port.

From: "D(dot) Jay Newman" <jay(at)sprucegrove(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] xlog.c.patch for cygwin port.
Date: 2000-03-08 02:48:28
Message-ID: 200003080248.VAA29840@sprucegrove.com (view raw or flat)
Thread:
Lists: pgsql-hackers
>> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> > This looks interesting.  We could remove some of our ifwin cruft.
>> 
>> I have been thinking for quite some time that most of the CYGWIN32
>> ifdefs represent very poor programming.  Instead of zillions of
>> 
>> #ifndef __CYGWIN32__
>> 	fd = open(filename, O_RDONLY, 0666);
>> #else
>> 	fd = open(filename, O_RDONLY | O_BINARY, 0666);
>> #endif
>> 
>> we should have in one include file something like
>
>Do we ever assign a function pointer for open() anywhere.  If so, the
>define will not work without some kind of wrapper, right?

Since the only difference seems to be "O_RDONLY" vs "O_RDONLY | O_BINARY",
why not do the #define on that?

At least in this case it works.
-- 
D. Jay Newman                   ! For the pleasure and the profit it derives
jay(at)sprucegrove(dot)com              ! I arrange things, like furniture, and
http://www.sprucegrove.com/~jay/   ! daffodils, and ...lives.  -- Hello Dolly

In response to

Responses

pgsql-hackers by date

Next:From: Lamar OwenDate: 2000-03-08 02:57:36
Subject: Re: [HACKERS] DROP TABLE inside a transaction block
Previous:From: Bruce MomjianDate: 2000-03-08 01:51:34
Subject: Re: [HACKERS] DROP TABLE inside a transaction block

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group