Re: Postgres ODBC

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Nick Gorham <nick(at)easysoft(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>, PostgreSQL-interfaces <pgsql-interfaces(at)postgreSQL(dot)org>
Subject: Re: Postgres ODBC
Date: 2000-02-14 12:32:40
Message-ID: 200002141232.HAA15711@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-interfaces

Patch applied. Thanks.

> Hi,
>
> I suspect that you are not the person to send this to, but I wasn't sure
> where else to mail it. I am the maintainer of unixODBC, and we have a
> set of code in our project that started life as the Postgres windows
> ODBC driver, which has been ported back to unix. Anyway I have just
> fixed a memory leak in the driver, and I cant see any mention of the fix
> being done in the main Postgres code, so I thougth I would let you know.
>
> Its in the statement.c module, after the COMMIT statement has been
> executed in SC_Execute, the code was
>
> /*// If we are in autocommit, we must send the commit. */
> if ( ! self->internal && CC_is_in_autocommit(conn) &&
> STMT_UPDATE(self)) {
> CC_send_query(conn, "COMMIT", NULL);
> CC_set_no_trans(conn);
> }
>
> I have changed it to
>
>
> /*// If we are in autocommit, we must send the commit. */
> if ( ! self->internal && CC_is_in_autocommit(conn) &&
> STMT_UPDATE(self)) {
> res = CC_send_query(conn, "COMMIT", NULL);
> QR_Destructor(res);
> CC_set_no_trans(conn);
> }
>
> Nick Gorham
>
>

--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Browse pgsql-hackers by date

  From Date Subject
Next Message Philip Warner 2000-02-14 13:17:55 Re: [HACKERS] Solution for LIMIT cost estimation
Previous Message Chris 2000-02-14 12:12:36 Solution for LIMIT cost estimation

Browse pgsql-interfaces by date

  From Date Subject
Next Message Joel Reed 2000-02-14 14:14:44 libpq patch for binding tuples in result set to user-allocated memory
Previous Message Dave Page 2000-02-14 10:24:32 RE: [INTERFACES] pgAdmin on NT (NT4SP6)