Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Is backend-libpq's "PQexec/PQfn/portal" code dead?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Is backend-libpq's "PQexec/PQfn/portal" code dead?
Date: 1999-12-31 03:34:55
Message-ID: 199912310334.WAA02865@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Perhaps move to _deadcode directory.  That is usually what we do.

> As near as I can tell, there are four whole modules of dead code in
> src/backend/libpq/: be-dumpdata.c, be-pqexec.c, portal.c, portalbuf.c
> (plus some support code in tcop/dest.c).  These provide functions called
> PQexec and PQfn, which apparently were once backend-side equivalents
> to the frontend-libpq functions of the same names, as well as a whole
> bunch of other code that may once have been shared with frontend-libpq,
> but is so no longer.
> 
> The only externally referenced entry point to these modules is an
> undocumented SQL function "pqtest", which I strongly suspect no one
> is using.
> 
> I am strongly inclined to rip all this stuff out, because it's buggy.
> I've already found memory-leak problems and dangling-global-pointer
> problems, and there are probably more.  I'd say this code has been
> suffering from software rot for a long time.
> 
> Does anyone remember what this code was for, or know a reason to keep it
> (and fix it) instead of ripping it out?
> 
> 			regards, tom lane
> 
> ************
> 


-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist(at)candle(dot)pha(dot)pa(dot)us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 1999-12-31 05:54:06
Subject: LIKE fixed(?) for non-ASCII collation orders
Previous:From: Tom LaneDate: 1999-12-31 02:05:10
Subject: Re: [HACKERS] HEAP_MOVED_IN error during vacuum?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group