Re: [HACKERS] relcache.c leaks refcnts

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] relcache.c leaks refcnts
Date: 1999-09-06 02:34:53
Message-ID: 199909060234.WAA08390@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> I believe that relcache.c should provide a routine (to be called during
> abort cleanup) that will reset the refcnts of all relcache entries to
> 0 for a normal rel and 1 for a nailed-in rel. It might be a good idea
> to call this routine during normal xact commit, too, just in case
> someone forgets to decrement a refcnt they've incremented.
>
> My earlier idea of having RelationFlushRelation rebuild the cache entry
> if it couldn't flush it would also mask this particular symptom. But
> that wouldn't cure the gradual relcache growth that is likely to occur
> because of refcnt leakage. I still think we probably want to do that
> too, though.

Yes, amazing it was this broken. Clearing it makes sense.

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yu Cao 1999-09-06 06:55:56 Re: [HACKERS] PostgreSQL 6.5.1: libpq++ libraries on IRIX 6.5
Previous Message Vadim Mikheev 1999-09-06 01:09:47 Re: [HACKERS] DROP TABLE inside transaction block