Skip site navigation (1) Skip section navigation (2)

Re: Fix spinlock usage in UnpinBuffer()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Fix spinlock usage in UnpinBuffer()
Date: 2005-12-29 18:13:25
Message-ID: 19982.1135880005@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu> writes:
> Remove SpinLockAcquire_NoHoldoff() and related. Now SpinLockAcquire() will
> not holdoff cancle/die interrupts. This will give cleaner and clearer
> useage of spinlock and also save a few cycles.

Applied with some minor comment updates.

I noticed that shmem.c holds ShmemIndexLock considerably longer than any
other spinlock is held, and across operations that could theoretically
fail (hashtable manipulations).  This doesn't matter a lot in the Unix
code because only the postmaster ever executes ShmemInitStruct, but
in the Windows port we run that code every time a backend is launched.
I think that we could convert that spinlock to an LWLock.  Will look into it.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2005-12-29 18:44:43
Subject: Re: pl/python: fix ref leak on elog
Previous:From: Bruce MomjianDate: 2005-12-29 17:15:23
Subject: Re: to_char and i18n

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group