Skip site navigation (1) Skip section navigation (2)

RE: [PATCHES] Re: [HACKERS] bug with long serial names

From: PostgreSQL pseudo-user <pgsql(at)s2(dot)cello-us(dot)com>
To: lockhart(at)alumni(dot)caltech(dot)edu, pgsql-hackers(at)postgreSQL(dot)org, pgsql-patches(at)postgreSQL(dot)org
Subject: RE: [PATCHES] Re: [HACKERS] bug with long serial names
Date: 1998-12-29 19:12:04
Message-ID: 199812291912.OAA28717@s2.cello-us.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Hi,

This appears to have worked, but required a patch to your patch -- which I've attached.
The new version passes regression tests in a manner very similar to the old,
so I'm assuming all is well, here, and that you mistakenly sent me one
of the features I'm not ready for yet... (CONSTR_NULL was undefined).

I'm just a novice here, so please, please, correct it if necessary!

Thanks very much for the quick service!

*** analyze.c	1998/12/29 18:43:50	1.2
--- analyze.c	1998/12/29 18:48:53
***************
*** 7,13 ****
   *
   *
   * IDENTIFICATION
!  *	  $Header: /usr/local/ports/databases/postgres-6.4.1/work/postgresql-6.4.1/src/backend/parser/RCS/analyze.c,v 1.2 1998/12/29 18:43:50 pgsql Exp $
   *
   *-------------------------------------------------------------------------
   */
--- 7,13 ----
   *
   *
   * IDENTIFICATION
!  *	  $Header: /usr/local/ports/databases/postgres-6.4.1/work/postgresql-6.4.1/src/backend/parser/RCS/analyze.c,v 1.3 1998/12/29 18:48:50 pgsql Exp $
   *
   *-------------------------------------------------------------------------
   */
***************
*** 592,606 ****
  						constraint = lfirst(clist);
  						switch (constraint->contype)
  						{
- 							case CONSTR_NULL:
- 								/* We should mark this explicitly,
- 								 * so we can tell if NULL and NOT NULL are both specified
- 								 */
- 								if (column->is_not_null)
- 									elog(ERROR, "CREATE TABLE/(NOT) NULL conflicting declaration"
- 										 " for %s.%s", stmt->relname, column->colname);
- 								column->is_not_null = FALSE;
- 								break;
  
  							case CONSTR_NOTNULL:
  								if (column->is_not_null)
--- 592,597 ----




pgsql-hackers by date

Next:From: Vince VielhaberDate: 1998-12-29 19:19:52
Subject: Re: [HACKERS] cvsup message
Previous:From: Thomas G. LockhartDate: 1998-12-29 18:41:57
Subject: Re: [HACKERS] cvsup message

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group