Skip site navigation (1) Skip section navigation (2)

Re: Overruns (was: 'pgsql/src/backend/lib stringinfo.c')

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: goran(at)bildbasen(dot)se (Goran Thyni)
Cc: tgl(at)hub(dot)org, hackers(at)postgreSQL(dot)org
Subject: Re: Overruns (was: 'pgsql/src/backend/lib stringinfo.c')
Date: 1998-12-12 21:03:12
Message-ID: 199812122103.QAA04669@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
> > Does this remove the need for vsnprintf?
> 
> I don't think so,
> vsprintf is still used if 6 places in to src tree, 5 of them is in
> the backend. Each of these should be examined to determent wheater
> those can be rewritten or if vsnprintf is needed.
> 
> To make matter worse:
> 
> guevara-goran# pwd
> /usr/local/src/cvs/pgsql/src
> guevara-goran# grep -n sprintf `find .` | wc -l
>     875
> guevara-goran# cd backend/
> guevara-goran# grep -n sprintf `find .` | wc -l
>     474
> 
> Their is lot of potential overruns in there,
> and since pgsql is a net(-able) server we
> should take that seriously.
> 
> I will look closer at these issues as time permits. 


Added to TODO:

	* fix any sprintf() overruns
	* add portable vsnprintf()


-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist(at)candle(dot)pha(dot)pa(dot)us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 1998-12-12 22:08:31
Subject: Re: [HACKERS] memory leak with Abort Transaction
Previous:From: Bruce MomjianDate: 1998-12-12 20:57:09
Subject: Re: OK now :-) was Re: [HACKERS] regression tests

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group