Re: Overruns (was: 'pgsql/src/backend/lib stringinfo.c')

> > Does this remove the need for vsnprintf?
>
> I don't think so,
> vsprintf is still used if 6 places in to src tree, 5 of them is in
> the backend. Each of these should be examined to determent wheater
> those can be rewritten or if vsnprintf is needed.
>
> To make matter worse:
>
> guevara-goran# pwd
> /usr/local/src/cvs/pgsql/src
> guevara-goran# grep -n sprintf `find .` | wc -l
> 875
> guevara-goran# cd backend/
> guevara-goran# grep -n sprintf `find .` | wc -l
> 474
>
> Their is lot of potential overruns in there,
> and since pgsql is a net(-able) server we
> should take that seriously.
>
> I will look closer at these issues as time permits.

Added to TODO:

* fix any sprintf() overruns
* add portable vsnprintf()

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026