Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Core dump in regression tests.

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: emkxp01(at)mtcc(dot)demon(dot)co(dot)uk
Cc: szybist(at)boxhill(dot)com, hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Core dump in regression tests.
Date: 1998-08-30 23:24:55
Message-ID: 199808302324.TAA28018@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
> I recompiled the latest cvs with -O2 and found that the crash on
> table creation was NOT now failing so I'm a little confused :-(
> 
> I'm just updating my cvs, and will do another build and see how
> things go.
> 
> If only I had the same failures as before I'd be able to confirm
> your suspicions on indexing.c
> 
> Til Later,
> Keith.
> 
> 
> 

OK, I am applying my patch now.  I certainly fixes a potential problem,
so I suspect it will fix the problems you are seeing.

Thomas, perhaps it will fix the regression problems too.  No way to
know.

Here is the new while loop.  Much better.

---------------------------------------------------------------------------


    sd = index_beginscan(idesc, false, num_keys, skey);
    while (indexRes = index_getnext(sd, ForwardScanDirection))
    {
        ItemPointer iptr;

        iptr = &indexRes->heap_iptr;
        tuple = heap_fetch(heapRelation, SnapshotNow, iptr, &buffer);
        pfree(indexRes);
        if (HeapTupleIsValid(tuple))
            break;
    }

-- 
Bruce Momjian                          |  830 Blythe Avenue
maillist(at)candle(dot)pha(dot)pa(dot)us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

In response to

pgsql-hackers by date

Next:From: David HartwigDate: 1998-08-30 23:50:05
Subject: Re: [HACKERS] Core dump in regression tests.
Previous:From: Bruce MomjianDate: 1998-08-30 23:13:51
Subject: Re: [HACKERS] Core dump in regression tests.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group