Re: [HACKERS] Current sources?

From: t-ishii(at)sra(dot)co(dot)jp
To: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
Cc: dg(at)illustra(dot)com (David Gould), tih+mail(at)Hamartun(dot)Priv(dot)NO, scrappy(at)hub(dot)org, pgsql-hackers(at)postgreSQL(dot)org, t-ishii(at)sra(dot)co(dot)jp, daveh(at)insightdist(dot)com
Subject: Re: [HACKERS] Current sources?
Date: 1998-05-26 02:09:08
Message-ID: 199805260209.LAA15766@srapc451.sra.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>> I do not believe that this could ever have passed regression. Do we have
>> the whole patch to back out, or do we need to just "fix what we have now"?
>>
>> Also, perhaps we need to be more selective about checkins?
>
>Not sure. Marc and I reviewed it, and it looked very good. In fact, I
>would like to see more of such patches, of course, without the destroydb
>problem, but many patches have little quirks the author could not have
>anticipated.
>
>> {
>> JunkFilter *j = (JunkFilter *) ExecInitJunkFilter(targetList);
>> estate->es_junkFilter = j;
>> >>>> tupType = j->jf_cleanTupType; /* Added by daveh(at)insightdist(dot)com 5/20/98 */
>> }
>> else
>> estate->es_junkFilter = NULL;
>>
>> Here is my debug transcript for "drop database regression"
>
>Here is the original patch. I got it with the command:

I have just removed the patch using patch -R and confirmed that "drop
table", and "delete from" works again. regression tests also look
good, except char/varchar/strings.

Now I can start to create patches for snapshot...
--
Tatsuo Ishii
t-ishii(at)sra(dot)co(dot)jp

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message The Hermit Hacker 1998-05-26 02:23:29 Re: [HACKERS] Current sources?
Previous Message The Hermit Hacker 1998-05-25 22:43:26 Re: [HACKERS] Current sources?