Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Re: [PATCHES] patches for 6.2.1p6

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: scrappy(at)hub(dot)org (The Hermit Hacker)
Cc: dg(at)illustra(dot)com, lockhart(at)alumni(dot)caltech(dot)edu, dz(at)cs(dot)unitn(dot)it, hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Re: [PATCHES] patches for 6.2.1p6
Date: 1998-03-17 14:20:00
Message-ID: 199803171420.JAA12842@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
> 
> On Mon, 16 Mar 1998, David Gould wrote:
> 
> > If this will work, I am willing to hack this together tomorrow.
> > What is the time frame for accepting a patch like this?
> 
> 	Assuming that its *clean* (clean meaning that Bruce fully approves
> of it, as this is his area of the code...well, one of them
> *grin*)...tomorrow would be great :)  If Bruce has *any* doubts though, it
> doesn't go in until after I do the patch I want to do...

David, go for it.  The code is all local in two files, and I think you
can basically change all the do{test-and-set} while(lock-is-false)
loops to:

	do{test-and-set} while(lock-is-false && select ())

Pretty easy.  No need to test multiple platforms.  The ones where the
loop is integrated into the asm(), leave them for later.

-- 
Bruce Momjian                          |  830 Blythe Avenue
maillist(at)candle(dot)pha(dot)pa(dot)us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

In response to

Responses

pgsql-hackers by date

Next:From: Mattias KregertDate: 1998-03-17 14:28:30
Subject: Regression test
Previous:From: The Hermit HackerDate: 1998-03-17 13:17:58
Subject: Re: Unix Domain Sockets error (was Re: [HACKERS] Alpha initdb fixed!)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group