Re: [HACKERS] Just a couple minor nits...

From: Tom I Helbekkmo <tih(at)Hamartun(dot)Priv(dot)NO>
To: The Hermit Hacker <scrappy(at)hub(dot)org>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Just a couple minor nits...
Date: 1998-03-01 14:06:41
Message-ID: 19980301150641.07895@Hamartun.Priv.NO
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Feb 28, 1998 at 04:07:08PM -0400, The Hermit Hacker wrote:

> This goes out to everyone...try out configure now...I've just converted
> over all the -enable/-with options so that they use AC_ARG_{ENABLE,WITH},
> which are proper m4 macros, and which provide for the -help options...my
> first pass through, I futzed up something that broke configure, but this
> time through, it appears to be clean...

Doesn't work at all here. I've got the March 1 snapshot, and when I
say "--with-tcl --with-perl", it reports (immediately) that those
options are turned on...

checking setting USE_TCL... enabled
checking setting USE_PERL... enabled

...but that's the last I hear of it. It seems that the USE_TCL and
USE_PERL variables are not set properly, because no attempt is made to
find the header files and libraries later on.

As for my observation that the previous releases, tcl7.6 and tk4.2,
also seem to work just fine:

> Take a look around line 611 in configure.in and let me know what
> you'd like to have added or changed...

I was thinking something along the lines of:

*** configure.in.orig Sun Mar 1 09:00:33 1998
--- configure.in Sun Mar 1 14:30:04 1998
***************
*** 564,570 ****
then
TCL_INCDIR=no
AC_CHECK_HEADER(tcl.h, TCL_INCDIR=)
! for f in /usr/include /usr/include/tcl8.0 /usr/local/include /usr/local/include/tcl8.0; do
if test "$TCL_INCDIR" = "no"; then
AC_CHECK_HEADER($f/tcl.h, TCL_INCDIR=$f)
fi
--- 564,570 ----
then
TCL_INCDIR=no
AC_CHECK_HEADER(tcl.h, TCL_INCDIR=)
! for f in /usr/include /usr/include/tcl8.0 /usr/include/tcl7.6 /usr/local/include /usr/local/include/tcl8.0 /usr/local/include/tcl7.6; do
if test "$TCL_INCDIR" = "no"; then
AC_CHECK_HEADER($f/tcl.h, TCL_INCDIR=$f)
fi
***************
*** 580,586 ****
if test "$USE_TCL" = "true"
then
TCL_LIB=
! for f in tcl8.0 tcl80; do
if test -z "$TCL_LIB"; then
AC_CHECK_LIB($f, main, TCL_LIB=$f)
fi
--- 580,586 ----
if test "$USE_TCL" = "true"
then
TCL_LIB=
! for f in tcl8.0 tcl80 tcl7.6 tcl76; do
if test -z "$TCL_LIB"; then
AC_CHECK_LIB($f, main, TCL_LIB=$f)
fi
***************
*** 610,616 ****

TK_INCDIR=no
AC_CHECK_HEADER(tk.h, TK_INCDIR=)
! for f in /usr/include /usr/include/tk8.0 /usr/local/include /usr/local/include/tk8.0; do
if test "$TK_INCDIR" = "no"; then
AC_CHECK_HEADER($f/tk.h, TK_INCDIR=$f)
fi
--- 610,616 ----

TK_INCDIR=no
AC_CHECK_HEADER(tk.h, TK_INCDIR=)
! for f in /usr/include /usr/include/tk8.0 /usr/include/tk4.2 /usr/local/include /usr/local/include/tk8.0 /usr/local/include/tk4.2; do
if test "$TK_INCDIR" = "no"; then
AC_CHECK_HEADER($f/tk.h, TK_INCDIR=$f)
fi
***************
*** 631,637 ****
if test "$USE_TCL" = "true"
then
TK_LIB=
! for f in tk8.0 tk80; do
if test -z "$TK_LIB"; then
AC_CHECK_LIB($f, main, TK_LIB=$f)
fi
--- 631,637 ----
if test "$USE_TCL" = "true"
then
TK_LIB=
! for f in tk8.0 tk80 tk4.2 tk42; do
if test -z "$TK_LIB"; then
AC_CHECK_LIB($f, main, TK_LIB=$f)
fi

-tih
--
Popularity is the hallmark of mediocrity. --Niles Crane, "Frasier"

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael 1998-03-01 15:16:50 very minor CFLAGS/COPT request
Previous Message Maurice Gittens 1998-03-01 12:11:03 Oid bug or feature?