Skip site navigation (1) Skip section navigation (2)

Re: pgcrypto: Makefile check

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pgcrypto: Makefile check
Date: 2004-11-23 00:10:13
Message-ID: 19887.1101168613@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Neil Conway <neilc(at)samurai(dot)com> writes:
> Perhaps I wasn't clear: the *present* behavior of pgcrypto is to
> "compile successfully but ... be unusable" if an invalid random source
> is defined. This is prone to error. That patch changes this behavior to
> refuse to compile if an invalid random source has been defined.

Ah, got it.

> I don't think this is a problem (an invalid random source is effectively
> a misconfiguration and could only be the result of user error). But if
> you like I can change the patch so that we error out when attempting to
> compile random.c

Please do; I dislike makefiles that won't "make clean" ...

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2004-11-23 00:22:04
Subject: Re: another plperl bug
Previous:From: Neil ConwayDate: 2004-11-22 23:42:38
Subject: Re: pgcrypto: Makefile check

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group