Re: Getting rid of warnings

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Getting rid of warnings
Date: 2007-01-25 15:57:29
Message-ID: 19872.1169740649@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> bool
> ! isort(int4 *a, int len)
> {
> bool
> ! isort(int4 *a, const int len)
> {

If VC thinks that that is required to fix a warning, it's too broken to live.
AFAICS what you've got there is a compiler that is being pedantically
strict about language details that it does not actually understand well;
its apparent idea that "const **" means "const * const *" being much in
the same line as this one.

I don't mind the non-const-related parts of this patch, but I recommend
rejecting all the const-decoration changes.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Teodor Sigaev 2007-01-25 16:06:16 Re: tsearch in core patch, for inclusion
Previous Message Magnus Hagander 2007-01-25 15:11:23 setlocal to build.bat