Skip site navigation (1) Skip section navigation (2)

plpython thinks it's hooked into "make distprep", but not so much

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: plpython thinks it's hooked into "make distprep", but not so much
Date: 2011-06-10 00:36:48
Message-ID: 19848.1307666208@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
I noticed while wrapping 9.1beta2 that plpython tries to build a file
spiexceptions.h to be included in the tarballs, but no such file is
actually appearing therein.  The reason is that src/pl/Makefile doesn't
recurse into the plpython subdirectory unless with_python is set.
Which it isn't, because the tarball build script doesn't configure
--with-python (or with any other options for that matter).  If it did,
it would fail, since there's no python installation on
developer.postgresql.org.

I left this go for the moment, since the only implication is that you
have to have perl available to build plpython from the tarball.  But we
oughta fix it before final.  Any opinions on what's the least ugly way
to get control to recurse to src/pl/plpython for "make distprep"
regardless of with_python?

(More generally, I would like to see cleanup targets such as make
distclean and make maintainer-clean recurse to all subdirectories
regardless of configure options, but that might be too much to ask for
right now.)

			regards, tom lane

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2011-06-10 00:59:04
Subject: Re: [v9.2] Start new timeline for PITR
Previous:From: Josh BerkusDate: 2011-06-10 00:02:48
Subject: Re: [v9.2] Start new timeline for PITR

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group