Skip site navigation (1) Skip section navigation (2)

Re: Removing savepointLevel from TransactionState

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>
Cc: PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Removing savepointLevel from TransactionState
Date: 2011-09-29 05:11:52
Message-ID: 19847.1317273112@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> writes:
> I noticed that the savepointLevel member of TransactionStateData struct is
> initialized to 0 from TopTransactionStateData, and never incremented or
> decremented afterwards.

> Since this is a file-local struct I think we can simply get rid of all
> usages of this without any risk.

ISTM you have detected a bug, not just dead code that should be removed.
Surely those tests that throw error on savepointLevel change were
meant to do something important?

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Gurjeet SinghDate: 2011-09-29 05:22:46
Subject: Re: Removing savepointLevel from TransactionState
Previous:From: Peter EisentrautDate: 2011-09-29 03:28:19
Subject: Re: pg_upgrade - add config directory setting

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group