Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> writes:
> I noticed that the savepointLevel member of TransactionStateData struct is
> initialized to 0 from TopTransactionStateData, and never incremented or
> decremented afterwards.
> Since this is a file-local struct I think we can simply get rid of all
> usages of this without any risk.
ISTM you have detected a bug, not just dead code that should be removed.
Surely those tests that throw error on savepointLevel change were
meant to do something important?
regards, tom lane
In response to
pgsql-hackers by date
|Next:||From: Gurjeet Singh||Date: 2011-09-29 05:22:46|
|Subject: Re: Removing savepointLevel from TransactionState|
|Previous:||From: Peter Eisentraut||Date: 2011-09-29 03:28:19|
|Subject: Re: pg_upgrade - add config directory setting|