Re: [HACKERS] Re: Rules with Conditions: Bug, or Misunderstanding

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: mhh(at)mindspring(dot)com
Cc: "Joel Burton" <jburton(at)scw(dot)org>, pgsql-hackers(at)postgresql(dot)org, pgsql-sql(at)postgresql(dot)org
Subject: Re: [HACKERS] Re: Rules with Conditions: Bug, or Misunderstanding
Date: 2000-12-01 05:33:22
Message-ID: 1984.975648802@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-sql

Mark Hollomon <mhh(at)mindspring(dot)com> writes:
> On Wednesday 29 November 2000 19:42, Tom Lane wrote:
>> Hm. Perhaps the "cannot update view" test is too strict --- it's not
>> bright enough to realize that the two rules together cover all cases,
>> so it complains that you *might* be trying to update the view. As the
>> code stands, you must provide an unconditional DO INSTEAD rule to
>> implement insertion or update of a view.

> It is in InitPlan, the same place we check to make sure that we are
> not changing a sequence or a toast table. (actually initResultRelInfo
> called from InitPlan). I gathered from the backend flowchart that this
> wasn't called until all rewriting was done. Was I wrong?

The rewriting is done, all right, but what's left afterward still has
references to the view, because each rule is conditional. Essentially,
the rewriter output looks like

-- rule 1
if (rule1 condition holds)
-- rule 2 applied to rule1 success case
if (rule2 condition holds)
apply rule 2's query
else
apply rule 1's query
else
-- rule 2 applied to rule1 failure case
if (rule2 condition holds)
apply rule 2's query
else
apply original query

If the system were capable of determining that either rule1 or rule2
condition will always hold, perhaps it could deduce that the original
query on the view will never be applied. However, I doubt that we
really want to let loose an automated theorem prover on the results
of every rewrite ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Don Baccus 2000-12-01 05:39:14 Re: beta testing version
Previous Message The Hermit Hacker 2000-12-01 04:00:12 Re: beta testing version

Browse pgsql-sql by date

  From Date Subject
Next Message Robert B. Easter 2000-12-01 06:32:12 Re: Help with Procedures in pgsql
Previous Message Tom Lane 2000-12-01 04:46:18 Re: pltcl: missing close-brace