Re: Warning compiling pg_dump (MinGW, Windows XP)

From: Pavel Golub <pavel(at)microolap(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pavel Golub <pavel(at)gf(dot)microolap(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Warning compiling pg_dump (MinGW, Windows XP)
Date: 2011-01-18 09:37:55
Message-ID: 198322025.20110118113755@gf.microolap.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello, Tom.

You wrote:

TL> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> 2011/1/13 Pavel Golub <pavel(at)microolap(dot)com>:
>>> pg_dump.c: In function 'dumpSequence':
>>> pg_dump.c:11449:2: warning: unknown conversion type character 'l' in format
>>> pg_dump.c:11449:2: warning: too many arguments for format

>> It seems like PGAC_FUNC_SNPRINTF_LONG_LONG_INT_FORMAT is getting the
>> wrong answer on your machine, though I'm not sure why.

TL> That configure check tests whether snprintf produces the right result at
TL> runtime. It doesn't check whether the compiler will generate a warning
TL> about it. It looks to me like Pavel has a compiler that is out of sync
TL> with his libc; which is a platform configuration mistake that he needs
TL> to fix.

The thing is that for this test I used a clean virtual machine under
WinXP with only one MinGW + MSYS installed.

TL> Another possibility is that configure chose to not use the system
TL> snprintf at all, in which case %lld is the correct syntax to use but gcc
TL> might well have some different expectation. Without seeing the
TL> config.log results it's hard to be sure about that one; but in any case
TL> it's hard to credit that there are any modern machines where snprintf
TL> can't handle long long int, so this still suggests a platform problem.

config.log attached

TL> regards, tom lane

--
With best wishes,
Pavel mailto:pavel(at)gf(dot)microolap(dot)com

Attachment Content-Type Size
config.zip application/x-zip-compressed 22.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Golub 2011-01-18 09:40:26 Re: Warning compiling pg_dump (MinGW, Windows XP)
Previous Message Susanne Ebrecht 2011-01-18 09:20:53 Re: Determining client_encoding from client locale