Re: patch contrib/pgcrypto for win32 (2)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Marko Kreen <marko(at)l-t(dot)ee>
Cc: "Korea PostgreSQL Users' Group" <pgsql-kr(at)postgresql(dot)or(dot)kr>, pgsql-patches(at)postgresql(dot)org
Subject: Re: patch contrib/pgcrypto for win32 (2)
Date: 2004-12-05 23:36:38
Message-ID: 19744.1102289798@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Marko Kreen <marko(at)l-t(dot)ee> writes:
> As for srandom, src/backend/postmaster/postmaster.c does it
> already, and doing it more will make matters only worse.

Yes. I think we had some discussion about that already, and concluded
it was a bad idea to insert ad-hoc srandom calls.

> I would not object to just sticking '& 255' there,

The patch actually says '% 255' which is a whole different animal;
it still requires explaining though.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Marko Kreen 2004-12-05 23:54:14 Re: patch contrib/pgcrypto for win32 (2)
Previous Message Marko Kreen 2004-12-05 23:27:27 Re: patch contrib/pgcrypto for win32 (2)