Skip site navigation (1) Skip section navigation (2)

Re: Why repalloc() != realloc() ?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why repalloc() != realloc() ?
Date: 2004-06-02 03:39:57
Message-ID: 19631.1086147597@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> Is there a reason why repalloc() does not behave the same as realloc?
> realloc(NULL, size) behaves the same as malloc(size), and it seems
> useful behavior -- I wonder why repalloc() chooses to Assert() against
> this exact condition?

We don't allow palloc(0) either, and we don't return NULL on failure,
and for that matter we don't allow pfree(NULL).  Please don't argue that
"we ought to be just like libc".

> I assume this is because the NULL pointer would not know what context it
> belongs to,

That's a sufficient reason from my point of view.  One of the main
properties of repalloc is that the alloc'd memory stays in the same
context it was first allocated in.  I'm not excited about allowing
a special exception that makes that behavior less predictable.

To give a concrete example of why this sort of corner-case exception is
bad, imagine an aggregate function or similar thing that concatenates
strings.  It starts with a palloc() in a specific context and then
assumes that repalloc's will stay in that context without prodding.
The code works fine --- unless there are corner cases for palloc(0)
returning NULL and repalloc() accepting NULL.

> Can this behavior be changed?

Not without a significantly better argument than you've offered.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2004-06-02 03:44:13
Subject: Re: Nested transactions and tuple header info
Previous:From: Bruce MomjianDate: 2004-06-02 03:17:40
Subject: Re: Nested transactions and tuple header info

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group