Re: [HACKERS] allowed user/db variables

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Andreas Pflug <Andreas(dot)Pflug(at)web(dot)de>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] allowed user/db variables
Date: 2003-06-25 23:52:56
Message-ID: 19475.1056585176@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Joe Conway <mail(at)joeconway(dot)com> writes:
> Here is a patch to expand pg_settings. I included more than discussed
> because it was easy and I thought it might be useful. Let me know if you
> want some of them removed.

Much of what you've included is part of the internal implementation of
GUC, and I think it's unwise to expose it; any future changes in GUC
might break the view (or more accurately break apps that are expecting
the view to look a particular way).

I agree with adding context, vartype, min_val, and max_val. Not sure
about boot_val or reset_val. The RH guys do want to expose boot_val
in their tool, since it's concerned with helping people set up
postgresql.conf, but is it really useful for clients to see it?
reset_val might be okay to expose ... not sure if we'd ever want to
remove that concept from the implementation.

> name | DateStyle
> setting | ISO with US (NonEuropean) conventions

This reminds me, someone (Barry?) was griping that SHOW DATESTYLE
doesn't produce a value that SET DATESTYLE will take. Did we agree
that it was OK to change the output to look like "ISO, US" etc?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message nolan 2003-06-25 23:55:48 Re: Updating psql for features of new FE/BE protocol
Previous Message Arguile 2003-06-25 23:36:34 Re: Updating psql for features of new FE/BE protocol

Browse pgsql-patches by date

  From Date Subject
Next Message Rod Taylor 2003-06-26 00:30:56 Re: src/bin/psql/input.c
Previous Message Joe Conway 2003-06-25 23:30:17 Re: [HACKERS] allowed user/db variables