Re: BUG #4869: No proper initialization of OpenSSL-Engine in libpq

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Lars Kanis <kanis(at)comcard(dot)de>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #4869: No proper initialization of OpenSSL-Engine in libpq
Date: 2009-06-22 16:05:12
Message-ID: 19329.1245686712@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> How about the attached patch? Does it work for you?

The existing references to typedef ENGINE and associated functions are
wrapped in

#if (SSLEAY_VERSION_NUMBER >= 0x00907000L) && !defined(OPENSSL_NO_ENGINE)

I rather imagine that this patch will cause complete failure in builds
where that's not true. I'm also a bit concerned about wrapping a struct
field inside such an #if, as that's likely to cause hard-to-debug
problems if two compilations read libpq-int.h with different #define
environments.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Magnus Hagander 2009-06-22 16:21:28 Re: BUG #4869: No proper initialization of OpenSSL-Engine in libpq
Previous Message Tom Lane 2009-06-22 15:46:22 Re: BUG #4869: No proper initialization of OpenSSL-Engine in libpq