| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Removing NONSEG mode |
| Date: | 2008-05-02 01:12:27 |
| Message-ID: | 19271.1209690747@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> I attach patch which remove nonsegment mode support. It was discussed during
> last commit fest. Nonsegment mode is possible uses only on couple of FS (ZFS,
> XFS) and it is not safe on any OS because each OS support more filesystems.
Applied with revisions --- mostly, you missed updating the
documentation, but also I didn't like the "LL" constant you used in
RELSEG_SIZE. It's unportable and there might be unexpected side effects
from having the macro represent an int64 constant instead of an integer.
So I had configure do the arithmetic and emit an integer.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2008-05-02 02:53:00 | Re: Fix \dT enum in psql |
| Previous Message | Pavel Stehule | 2008-05-01 18:36:10 | Re: temporal version of generate_series() |