From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Bruce Momjian <bruce(at)momjian(dot)us>
Cc:
Jeremy Drake <pgsql(at)jdrake(dot)com>,
Alvaro Herrera <alvherre(at)commandprompt(dot)com>,
pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject:
Re: pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge
Date:
2011-09-02 16:52:05
Message-ID:
19163.1314982325@sss.pgh.pa.us (view raw or flat )
Thread:
2011-09-01 11:22:43 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-01 14:10:12 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-01 14:49:36 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-01 15:42:46 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-01 18:07:11 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-02 06:48:31 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-02 15:20:50 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-02 15:38:28 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2011-09-02 16:11:00 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-02 16:44:28 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-02 16:52:05 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-03 05:54:33 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-03 14:23:09 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-03 14:39:15 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-04 07:13:53 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-04 07:29:00 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-05 07:07:49 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-05 13:45:09 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-05 19:53:55 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-05 19:55:51 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-05 20:19:19 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-03 14:35:41 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-02 16:53:12 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2011-09-04 00:51:13 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-04 01:08:41 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-04 01:25:17 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-04 01:48:38 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-04 04:30:43 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-04 05:18:01 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-12 19:11:21 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Lists:
pgsql-committers pgsql-hackers
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>>> instead. Don't use 'offsetof (struct s, d[0])', as this doesn't work with
>>> MSVC and with C++ compilers. */
>> D'oh ... I bet that last sentence is pointing us at the problem. cube
>> is using exactly that construct, and for some reason it's crashing.
> I see 35 instances of this coding, and only 12 are in contrib/cube;
> examples attached.
Yeah, so the next question would be why those other ones aren't showing
problems. But at least now we have a potential mechanism for getting
from "the include list changed" to "cube is crashing on an offsetof",
namely that something is affecting the expansion of the offsetof macro.
Up to now it's been black magic, and I don't like patching around
problems we don't understand any better than that.
regards, tom lane
In response to
Responses
pgsql-hackers by date
Next :From: Alvaro HerreraDate: 2011-09-02 16:53:12Subject : Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a GePrevious :From : Tom LaneDate : 2011-09-02 16:45:19Subject : Re: limit in subquery causes poor selectivity estimation
pgsql-committers by date
Next :From: Alvaro HerreraDate: 2011-09-02 16:53:12Subject : Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a GePrevious :From : Bruce MomjianDate : 2011-09-02 16:44:28Subject : Re: pgsql: Remove "fmgr.h" include in cube
contrib --- caused crash on a Ge
