Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p ...

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p ...
Date: 2004-05-19 18:21:11
Message-ID: 19032.1084990871@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> And tested?  I didn't say that I thought elog would work in main.c.
>> In fact I'm pretty certain it won't.

> Compiles/regression tests pass.  

You need to test the cases that will produce elog output.

> This is why I removed elog in the first place, because I thought it
> wouldn't work up higher before the guc load, but you said it would use
> the default.  Are you saying it only works after guc is loaded?

No, I specifically said it didn't need guc.  But it does need palloc,
which means MemoryContextInit() has to run first.  I could see running
find_my_exec immediately before InitializeGUCOptions() in PostmasterMain.

			regards, tom lane

In response to

Responses

pgsql-committers by date

Next:From: Bruce MomjianDate: 2004-05-19 18:58:45
Subject: pgsql-server/src/backend main/main.c postmaste ...
Previous:From: Bruce MomjianDate: 2004-05-19 17:37:45
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p ...

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-05-19 19:02:10
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p
Previous:From: Magnus HaganderDate: 2004-05-19 18:03:31
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p ...

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group