Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc
Date: 2011-05-24 21:58:30
Message-ID: 18842.1306274310@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> On 22.05.2011 21:18, Tom Lane wrote:
>> I'm also concerned that you've probably
>> added cycles on net to MemoryContextAlloc (where it's no longer possible
>> to tail-call AllocSetAlloc), which could very easily cost more cycles on
>> most workloads than could ever be saved by making MemoryContextReset a
>> shade faster.

> Good point. That would be solved by clearing the flag before the 
> AllocSetAlloc() call. I don't see any harm in clearing the flag before 
> actually doing the allocation.

Done that way.

			regards, tom lane

In response to

Responses

pgsql-committers by date

Next:From: Tom LaneDate: 2011-05-24 22:52:22
Subject: pgsql: Grammar cleanup for src/test/isolation/README
Previous:From: Tom LaneDate: 2011-05-24 21:57:44
Subject: pgsql: Cleanup for pull-up-isReset patch.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group