Skip site navigation (1) Skip section navigation (2)

Re: Libpq COPY optimization patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Alon Goldshuv" <agoldshuv(at)greenplum(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Libpq COPY optimization patch
Date: 2006-01-24 15:02:19
Message-ID: 18495.1138114939@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
"Alon Goldshuv" <agoldshuv(at)greenplum(dot)com> writes:
> Here is a patch against today's code 1/24. As discussed in -hackers
> consumeInput/parse is removed from being called every single time. It's
> still there for only when the data is sent to the server.

This appears to be the exact same patch you sent before.  Did you
test my suggestion of simply removing the PQconsumeInput call?
I see no reason to add it inside the loop.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2006-01-24 15:11:07
Subject: Re: [HACKERS] CIDR/INET improvements
Previous:From: Gustavo ToniniDate: 2006-01-24 10:17:22
Subject: Re: [PATCHES] postmaster/postgres merge for testing

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group