Re: Libpq COPY optimization patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Alon Goldshuv" <agoldshuv(at)greenplum(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Libpq COPY optimization patch
Date: 2006-01-24 15:02:19
Message-ID: 18495.1138114939@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Alon Goldshuv" <agoldshuv(at)greenplum(dot)com> writes:
> Here is a patch against today's code 1/24. As discussed in -hackers
> consumeInput/parse is removed from being called every single time. It's
> still there for only when the data is sent to the server.

This appears to be the exact same patch you sent before. Did you
test my suggestion of simply removing the PQconsumeInput call?
I see no reason to add it inside the loop.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-01-24 15:11:07 Re: [HACKERS] CIDR/INET improvements
Previous Message Gustavo Tonini 2006-01-24 10:17:22 Re: [PATCHES] postmaster/postgres merge for testing