Skip site navigation (1) Skip section navigation (2)

Re: BUG #6704: ALTER EXTENSION postgis SET SCHEMA leaves dangling relations

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: jeff <jeff(at)pgexperts(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #6704: ALTER EXTENSION postgis SET SCHEMA leaves dangling relations
Date: 2012-08-31 20:01:03
Message-ID: 18412.1346443263@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugs
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Here's a patch.

Looks reasonable, but please try a little harder on the comments for the
new function --- IMO it should have a header comment that explains what
it's supposed to do exactly.

> For some reason, AlterSeqNamespaces was being passed a schema name.
> This wasn't used and was not possible to keep in the patched code so I
> just removed it.

Probably a hangover from some previous state of the code.  If it's not
used I see no reason not to remove it.

			regards, tom lane


In response to

Responses

pgsql-bugs by date

Next:From: Alvaro HerreraDate: 2012-08-31 20:25:40
Subject: Re: BUG #6704: ALTER EXTENSION postgis SET SCHEMA leaves dangling relations
Previous:From: Tom LaneDate: 2012-08-31 19:20:13
Subject: Re: BUG #6758: ./configure script sets HAVE_WCSTOMBS_L 1

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group